regression: Scaladoc blows up in 2.11.x-jdk8 build after scala-xml changes #538
Assignees
Comments
|
So this only affects 2.11? And the errors are about missing definitions for scala-library? Unfortunately, those are two big changes, IMO. Although, if I had to guess , the exclude rule change should only be in the scope of the scala-compiler dependency for testing... The change scala/scala-xml@de0b47e from a few days prior dropped an import from |
yes
I don't know how to interpret the error yet.
I'll do a test run against scala/scala-xml@121034f shortly so we won't have to guess which one it was, at least |
|
121034f has the same problem, so looks like @lrytz will be answering for this at the gates of heaven, not you |
|
Ok, cool. Thanks for figuring that out. If it is Lukas's change, then it will also include the upgrade of sbt-scala-module: |
|
scala-xml build log: |
|
ok so that log is full of references to 2.12.2 even though this is a 2.11 build, so there you go |
|
ah OK I think I know what's going on here. Lukas assumed that we never want to build a 2.11 Scala module on JDK 8, and that logic is baked into sbt-scala-modules: that was a rather reasonable assumption, but it happens to be wrong in the context of the 2.11.x-jdk8 community build specifically. I will now attempt to override this in the community build config rather than having to change anything elsewhere. |
So, how did the community build work when the build.sbt for scala-xml was this? if (java.startsWith("1.6.") || java.startsWith("1.7."))
Seq("2.11.8")Or is building 2.11 on jdk8 new? |
not new. it is indeed mysterious why dbuild was able to override |
|
maybe this will help diff --git a/community.dbuild b/community.dbuild
index d4f19e3..fdec965 100644
--- a/community.dbuild
+++ b/community.dbuild
@@ -40,13 +40,13 @@ build += {
{
name: "scala-xml"
uri: "https://github.com/"${vars.scala-xml-ref}
- extra.commands: "set scalaVersion := \"2.11.8\""
+ extra.commands: "set every scalaVersion := \"2.11.8\""
extra.projects: ["xmlJVM"]
}
{
name: "scala-parser-combinators"
uri: "https://github.com/"${vars.scala-parser-combinators-ref}
- extra.commands: "set scalaVersion := \"2.11.8\""
+ extra.commands: "set every scalaVersion := \"2.11.8\""
extra.projects: ["scala-parser-combinatorsJVM"] |
|
haha deja vu, this is #142 (October 2015) all over again, except my fix wasn't quiiiite right before |
doh! you're both off the hook "In order that the happiness of the saints may be more delightful to them and that they may render more copious thanks to God for it, they are allowed to see perfectly the sufferings of the damned", said Thomas Aquinas, so @lrytz is going to be up there laughing at me wrestling with dbuild for all of eternity |
Just to clarify: the only thing the boolean flag does is define whether or not the version is included in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
last green build was scala/scala-xml@383f5fa https://scala-ci.typesafe.com/view/scala-2.11.x/job/scala-2.11.x-jdk8-integrate-community-build/372/
first failing build scala/scala-xml@8495b63 https://scala-ci.typesafe.com/view/scala-2.11.x/job/scala-2.11.x-jdk8-integrate-community-build/373/
scala-xml itself builds, but then multiple projects fail during Scaladoc generation, e.g.
relevant history in scala-xml repo:
I'll look into whether this is somehow just because we're in dbuild, or whether this is a real problem in the scala-xml repo
fyi @ashawley
The text was updated successfully, but these errors were encountered: