Skip to content

newer scala-logging, newer scoverage, unfreeze Shapeless, unfork Scala.js #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2016

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Sep 20, 2016

@SethTisue SethTisue self-assigned this Sep 20, 2016
@SethTisue
Copy link
Member Author

oh, I failed to notice there is some prior art on this in the config file, some of it commented out, some of it not. let's try removing it: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-integrate-community-build/588/consoleFull

@SethTisue
Copy link
Member Author

SethTisue commented Sep 20, 2016

ok, so this thing from the comments where scoverage wants a scala-logging-slf4j artifact rather than a scala-logging artifact is still an issue. perhaps this will get mired in a cascade of upgrades, but let's try newer scoverage forked to have the right form of scala-logging dependency:

@SethTisue SethTisue force-pushed the add-scala-logging branch 2 times, most recently from 4ea6df6 to d811eab Compare September 20, 2016 19:51
@SethTisue
Copy link
Member Author

SethTisue commented Sep 20, 2016

among other reasons this knot may be worth untangling: the 2.12 community build doesn't currently track Shapeless master (attn @milessabin, did you know this?) because of an scoverage dependency. I've added a commit to this PR returning to Shapeless master. knock on wood

@dwijnand
Copy link
Member

dwijnand commented Sep 20, 2016

The scoverage upgrade has been underway over the last few days. See scoverage/scalac-scoverage-plugin#177 and a few days worth of back and forth in the scoverage gitter room. Hopefully a release will be cut soon. Cats is also awaiting it.

@SethTisue
Copy link
Member Author

thanks, I was not aware. I've subscribed to that ticket

@SethTisue
Copy link
Member Author

omg it's green 🎉

scoverage: newer version
scala-logging: newer version
Shapeless: unfreeze
Scala.js: unfork
@SethTisue
Copy link
Member Author

squashed

@SethTisue SethTisue merged commit e0a615a into scala:2.12.x Sep 20, 2016
@SethTisue SethTisue changed the title add scala-logging newer scala-logging, newer scoverage, unfreeze Shapeless, unfork Scala.js Sep 20, 2016
@SethTisue
Copy link
Member Author

fyi @analytically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants