Skip to content

disable Akka tests known to fail on JDK 9 or 10 #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 26, 2018

Conversation

SethTisue
Copy link
Member

No description provided.

@SethTisue
Copy link
Member Author

@SethTisue SethTisue self-assigned this Jul 12, 2018
@SethTisue
Copy link
Member Author

https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk9-integrate-community-build/261/ shows another problem that needs fixing before akka-more will be green: [akka-more:error] java.lang.NoClassDefFoundError: javax/xml/bind/annotation/XmlRootElement

@SethTisue
Copy link
Member Author

SethTisue commented Jul 12, 2018

@SethTisue
Copy link
Member Author

@SethTisue
Copy link
Member Author

SethTisue commented Jul 13, 2018

[akka-stream] [error] Failed tests:
[akka-stream] [error] 	akka.remote.serialization.MiscMessageSerializerSpec

perhaps intermittent? let's see: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk9-integrate-community-build/276/ (404 for now)

(perhaps it was already failing before, or it never got the chance to fail because some other subproject failed first? I didn't check)

@SethTisue
Copy link
Member Author

failed again, apparently not intermittent. let's try JDK10: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk10-integrate-community-build/68/

@SethTisue
Copy link
Member Author

SethTisue commented Jul 13, 2018

hmm, JDK 10 didn't get past akka-actor, [akka-actor] [error] akka.pattern.CircuitBreakerSpec failed, not sure if intermittent? queued another run: https://scala-ci.typesafe.com/view/scala-2.12.x/job/scala-2.12.x-jdk10-integrate-community-build/70/

@SethTisue
Copy link
Member Author

same result. I should report it upstream

@SethTisue
Copy link
Member Author

I commented on akka/akka#23402

@SethTisue
Copy link
Member Author

@SethTisue SethTisue changed the title disable an Akka test known to fail on JDK 9 only disable Akka tests known to fail on JDK 9 or 10 Jul 18, 2018
@SethTisue
Copy link
Member Author

gah

[akka-actor] [error] /home/jenkins/workspace/scala-2.12.x-jdk10-integrate-community-build/target-0.9.12/project-builds/akka-actor-b454a7b577ffd7774882613b44b77d1f5836b1c1/akka-actor/src/main/scala/akka/util/Unsafe.java:14:29: object misc is not a member of package sun
[akka-actor] [error]     public static final sun.misc.Unsafe instance;
[akka-actor] [error]                             ^

@SethTisue
Copy link
Member Author

SethTisue commented Jul 18, 2018

project/AkkaBuild.scala has:

  // -XDignore.symbol.file suppresses sun.misc.Unsafe warnings
  final val DefaultJavacOptions = Seq("-encoding", "UTF-8", "-Xlint:unchecked", "-XDignore.symbol.file")

is this an OpenJDK vs. OracleJDK thing?

jenkins@ip-172-31-2-4:~$ echo $JAVA_HOME
/usr/lib/jvm/java-10-openjdk-x64
jenkins@ip-172-31-2-4:~$ cat J.java
public interface J {
    sun.misc.Unsafe foo();
}
jenkins@ip-172-31-2-4:~$ $JAVA_HOME/bin/javac J.java
J.java:2: warning: Unsafe is internal proprietary API and may be removed in a future release
    sun.misc.Unsafe foo();
            ^
1 warning

gah, sun.misc.Unsafe exists in OpenJDK too, so how can "object misc is not a member of package sun " be happening?

@SethTisue
Copy link
Member Author

the sun.misc.Unsafe thing isn't this PR's fault, it's also happening in the regular jdk9 and jdk10 builds

@SethTisue
Copy link
Member Author

Ima go ahead and merge this, and pursue the sun.misc.Unsafe thing separately

@SethTisue SethTisue merged commit 679dbce into scala:2.12.x Jul 26, 2018
@SethTisue SethTisue deleted the akka-indexspec branch July 26, 2018 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant