Skip to content

Fixed/improved some wording and punctuation. #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Fixed/improved some wording and punctuation. #1271

merged 1 commit into from
Feb 4, 2019

Conversation

dsbos
Copy link
Contributor

@dsbos dsbos commented Jan 27, 2019

No description provided.

provides several `Duration` subclasses for implicit conversion purposes and those should
not be used.

Abstract `Duration` contains methods that allow :
Abstract `Duration` contains methods that allow:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about,

Abstract `Duration`s contain methods that allow:

or,

An abstract `Duration` contains methods that allow:

?

Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(no opinion on whether Jon's proposed change should be made before this is merged, I'm fine either way)

@SethTisue SethTisue merged commit 609cd62 into scala:master Feb 4, 2019
@SethTisue
Copy link
Member

thanks @dsbos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants