Small cheatsheet fixes #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

SethTisue merged 18 commits into scala:master from toy:small-cheatsheet-fixes

Jul 31, 2019

Contributor

toy commented Jul 24, 2019

A lot of added and removed whitespace, added dots, capitalisation + few slightly changed and one fixed example.

Member

ashawley commented Jul 25, 2019

Thanks for doing this. I fixed a lot of formatting in #1280, but knew it still needed more work.

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

Contributor Author

toy commented Jul 25, 2019

@ashawley Please have a look once more
Seems I can't re-request review :)

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

ashawley reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

julienrf reviewed

View reviewed changes

_overviews/cheatsheets/index.md Outdated Show resolved Hide resolved

Contributor Author

toy commented Jul 29, 2019

@ashawley @julienrf Please have a look once more

Member

ashawley commented Jul 30, 2019

Looks good to me. Thanks again for doing this.

Member

SethTisue commented Jul 30, 2019

needs rebase

toy added 13 commits

July 31, 2019 01:07


          whitespace, dots, formatting

d6c7f77


          note about import scala.language.postfixOps

a29722f


          note about Option(null) != Some(null)

5c0315e


          note about foreach returning Unit

02c4981


          fix false to true in return of None.forall

cd381e2


          change examples of flatten and collect

3644e68


          change example for exists

46e3670


          more whitespace, dots, formatting

397aaa0


          fix weird looking <code>Unit</code>-returning

05626b9


          remove postfixOps example

03fe9c0


          insert space between colon and type in last few places

2fb91c3


          last missed "For comprehension" => "For-comprehension"

63f5d9f


          mark sprintf function with <code>

6ee4178

toy added 5 commits

July 31, 2019 01:07


          revert example for flatten

472b9eb


          expand and unify style of collect, exists and forall examples

295b136


          remove returning Unit in the end of foreach example

e212ccc


          add note about procedure syntax been deprecated in 2.13

f67f26d


          remove note about foreach returning Unit

f1da6cd

toy force-pushed the small-cheatsheet-fixes branch from 95a5f41 to f1da6cd Compare

July 30, 2019 23:08

Contributor Author

toy commented Jul 30, 2019

@SethTisue Done

SethTisue merged commit 3bbc21b into scala:master

Member

SethTisue commented Jul 31, 2019

awesome, thanks for this!

toy deleted the small-cheatsheet-fixes branch

July 31, 2019 00:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet