Skip to content

Show all Scaladoc options #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2017

Conversation

som-snytt
Copy link
Contributor

Demonstrate the styles of indentation without prejudice.

@som-snytt som-snytt requested a review from SethTisue June 17, 2017 07:24
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does a good job of summarizing the three major conventions I've seen in the wild. It seems the "Scaladoc" style aligned by the first asterisk is used in projects like

while the "Javadoc" style is used in libraries like

The third one is used by poor souls like myself who followed the old recommendations on the official style-guide.

def myMethod = {}
def member: Unit = ()

Scaladoc style, with gutter asterisks aligned in column two:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/ScaLadoc/Scaladoc/ ?

@eddsteel
Copy link

To fix the issue where tools/editors refer to "Scaladoc style", could these have names? I've seen flat and ragged used elsewhere. Thus your options could be "Javadoc", "Flat Scaladoc", "Ragged Scaladoc".

@olafurpg
Copy link
Contributor

olafurpg commented Jun 17, 2017

I totally agree @eddsteel, if the official guide will advertise three different styles then it should give each style a name. However, I think we should first try to see if we can agree on a single style first and avoid the need for coming up with three names. Let's continue this discussion in https://contributors.scala-lang.org/t/quiet-changes-to-the-style-guide/923/6

@SethTisue
Copy link
Member

hey @som-snytt, rebase? and then let's get this merged. in the absence of any broader changes to how the style guide is managed, in the meantime we might as well merge this, it reflects the current status quo

Demonstrate the styles of indentation without prejudice.
@som-snytt som-snytt force-pushed the issue/comment-style-follow-up branch from fa298e5 to b6ea1d3 Compare October 10, 2017 21:38
@SethTisue SethTisue merged commit 9d61471 into scala:master Oct 15, 2017
@SethTisue
Copy link
Member

thanks, A.P.!

@som-snytt
Copy link
Contributor Author

@SethTisue N.P.

@som-snytt som-snytt deleted the issue/comment-style-follow-up branch March 21, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants