Skip to content

Remove use of scala.concurrent.forkjoin #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2018
Merged

Remove use of scala.concurrent.forkjoin #192

merged 1 commit into from
Mar 14, 2018

Conversation

NthPortal
Copy link
Contributor

Fixes #191

@NthPortal
Copy link
Contributor Author

It looks like this is failing because ForkJoinPool didn't exist in Java 6. How did this actually ever work with Java 6?

@retronym
Copy link
Member

retronym commented Mar 14, 2018 •
edited
Loading

The failure is the (2.11.12 / JDK6) entry in the cross building matrix. 2.11 still contains s.c.ForkJoinPool, rather than the deprecated aliases.

I'm happy to drop support for Java 6 as a solution for this, you could remove it from .travis.yml and here in build.sbt as part of this PR.

@NthPortal
Copy link
Contributor Author

I note that removing that line from build.sbt leaves no mapping from 2.11 to true

@retronym
Copy link
Member

retronym commented Mar 14, 2018 via email

@NthPortal
Remove use of scala.concurrent.forkjoin
1a7972f 
Remove use of scala.concurrent.forkjoin.

Remove support for JDK 6.
@SethTisue SethTisue merged commit e7f8948 into scala:master Mar 14, 2018
@SethTisue
Copy link
Member

thank you

@NthPortal NthPortal deleted the forkjoin-fix branch March 14, 2018 17:53
@retronym retronym added this to the 0.10 milestone Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@NthPortal @retronym @SethTisue