-
Notifications
You must be signed in to change notification settings - Fork 90
publish master commits with date + commit hash #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think sbt-dynver would be helpful here? |
I'm not too familiar with sbt (we use Gradle for our Scala builds at work) but it looks like grabbing the git commit with sbt-dynver wouldn't be much different from |
Oh I see what you mean -- are you suggesting that the version should be based on the lastest master version tag? I was thinking of keeping |
yeah, having the previous tag in the version number helps humans keep track of what they're depending on, and I've found sbt-dynver to be painless to use |
@SethTisue updated to use sbt-dynver |
This comment has been minimized.
This comment has been minimized.
the latest sbt-scala-module version brings in sbt-dynver, so it isn't necessary to add it separately anymore I apologize for neglecting this PR. here of some of the reasons I've had hesitations about it:
anyway, those are some of the thoughts that swirled around in my mind every time I thought about what to do with this PR @dsilva not sure if you're still around/interested. but in any case, the status quo remains, if you want to test something, either |
@SethTisue Thanks for following up here and for explaining this from Lightbend's perspective. That all sounds reasonable. The original motivation for this was a situation where there were unreleased changes in master. It sounds like sbt-ci-release addresses that. At some point, Lightbend might want to try automated/continuous publishing to see if it's a good fit for the open source projects that Lightbend maintains, but maybe for something not as high profile as scala-async. |
I don't have a close button here, but feel free to close this :) |
Suggested versioning scheme for https://github.com/scala/scala-async/issues/205