Fix ownership corruption problem in the awaited expression

[retronym]

Previously, whyDoYouHateMe was incorrectly owned by jerk,
rather than pointlessSymbolOwner after the ANF transform,
which in turn led to:

java.util.NoSuchElementException: value whyDoHateMe
    at scala.collection.mutable.AnyRefMap$ExceptionDefault.apply(AnyRefMap.scala:425)
    at scala.collection.mutable.AnyRefMap$ExceptionDefault.apply(AnyRefMap.scala:424)
    at scala.collection.mutable.AnyRefMap.apply(AnyRefMap.scala:180)
    at scala.tools.nsc.backend.jvm.BCodeSkelBuilder$PlainSkelBuilder$locals$.load(BCodeSkelBuilder.scala:390)
    at scala.tools.nsc.backend.jvm.BCodeBodyBuilder$PlainBodyBuilder.genLoad(BCodeBodyBuilder.scala:354)

[SethTisue]

Previously, whyDoYouHateMe was incorrectly owned by jerk

best ticket ever

[pnf]

This is the greatest moment of my life.

…

On Thu, Feb 7, 2019, at 03:11, Seth Tisue wrote: > Previously, `whyDoYouHateMe` was incorrectly owned by `jerk` best ticket ever — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#210 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABNP7ZJo3eDbGw_dRyM_0FaQusn8cK0Hks5vK9-2gaJpZM4amq77>.

[hrhino]

Thank you!

I should start using more fanciful identifiers in my bug reports.

[pnf]

Unfortunately, the following, which passed without the change to LateAnfTransform.scala, will now fail:

  @Test def testByNameOwner2(): Unit = {
    val result = run(
      """
      import scala.async.run.late.{autoawait,lateasync}
      object Bleh {
        @autoawait @lateasync def bleh = Bleh
        def byName[T](fn: => T): T = fn
      }
      object Boffo {
        @autoawait @lateasync def slob(): Unit = {
          val pointlessSymbolOwner =  {
              Bleh.bleh.byName {
                val whyDoHateMeToo = 1
                whyDoHateMeToo
              }
          }
        }
      }
      object Test {
        @lateasync def test() = Boffo.slob()
      }
      """)
  }

[retronym]

@pnf Thanks for the test case. I've spotted the error in my first attempt and pushed a change that deals equally well with slobs and jerks. 😄