Skip to content

mutable.Queue.enqueueAll #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2020
Merged

mutable.Queue.enqueueAll #325

merged 1 commit into from
Sep 3, 2020

Conversation

samzilverberg
Copy link
Contributor

adding compat support for mutable.Queue.enqueueAll

immutable.Queue.enqueueAll support was added before in:
#304

so extending to mutable was pretty straight forward

did:

  • code copmiles and tests are green on projects: compat211, compat212, compat213
  • scalafmt is happy

@samzilverberg
Copy link
Contributor Author

travis says i need to first

Please sign the Scala CLA to contribute to scala/scala-collection-compat

so brb with a signature 😁

@samzilverberg samzilverberg force-pushed the mutable-queue-compat-enqueueall branch from 774361e to 9d36ad4 Compare April 23, 2020 21:19
@samzilverberg samzilverberg force-pushed the mutable-queue-compat-enqueueall branch from 9d36ad4 to 8c7f7ed Compare April 23, 2020 21:48
@samzilverberg
Copy link
Contributor Author

most of travis build stages are green but then some seem to fail when checking for CLA:
https://travis-ci.org/github/scala/scala-collection-compat/jobs/678793556

Incoming pull request from https://github.com/scala/scala-collection-compat/pull/325
Pull request submitted by null
CLA check for null failed

null? what?

@samzilverberg
Copy link
Contributor Author

the problem resolved itself after waiting some more.

@SethTisue SethTisue merged commit 3215ff3 into scala:master Sep 3, 2020
@SethTisue
Copy link
Member

thank you! apologies for the very long delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samzilverberg @SethTisue