Skip to content

Prevent scala-{library,reflect} from depending on JVM code outside of compact1 profile #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adriaanm opened this issue Nov 7, 2017 · 2 comments
Closed

Prevent scala-{library,reflect} from depending on JVM code outside of compact1 profile #437

adriaanm opened this issue Nov 7, 2017 · 2 comments
Assignees
@dwijnand
Labels
enhancement t:build t:java9 t:modularize
Milestone
2.13.0-M5

Comments

@adriaanm
Copy link
Contributor

adriaanm commented Nov 7, 2017 •
edited
Loading

In 2.13.0-M3, we will have shed all dependencies outside of the compact1 profile. Let's make sure to keep it that way.
@adriaanm
Copy link
Contributor Author

adriaanm commented Nov 7, 2017

Can we use jdeps somehow?

@adriaanm adriaanm added this to the 2.13.0-M5 milestone Jun 14, 2018
@adriaanm adriaanm mentioned this issue Jun 14, 2018
Closed
@adriaanm
Copy link
Contributor Author

@dwijnand could you take a stab at integrating my proposed test over at scala/scala#6164 (comment) into the build?

@adriaanm adriaanm mentioned this issue Jun 14, 2018
Closed
dwijnand added a commit to dwijnand/scala that referenced this issue Jun 14, 2018
@dwijnand
Enforce library/reflect restriction to compat1 profile
3528ca6 
Enforcement of scala#6164

Tested manually by reverting the sys.process.javaVmArguments change
07ff7ac and then running testJDepsImpl:

    > testJDeps
    [info] Compiling 1 Scala source to /d/scala/build/quick/classes/library...
    [info] Packaging /d/scala/build/pack/lib/scala-library.jar ...
    [info] Packaging /d/scala/build/pack/lib/scala-reflect.jar ...
    [info] Done packaging.
    [info] Done packaging.
    [trace] Stack trace suppressed: run last root/*:testJDeps for the full output.
    [error] (root/*:testJDeps) Detected dependency outside of compact1:
    [error] scala-library.jar -> /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre/lib/rt.jar (compact3)
    [error] scala-reflect.jar -> /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre/lib/rt.jar (compact1)
    [error] scala-reflect.jar -> /d/scala/build/pack/lib/scala-library.jar
    [error] Total time: 4 s, completed 14-Jun-2018 14:20:02

Fixes scala/scala-dev#437
Fixes scala/bug#10559
@dwijnand dwijnand mentioned this issue Jun 14, 2018
Merged
dwijnand added a commit to dwijnand/scala that referenced this issue Jun 14, 2018
@dwijnand
Enforce library/reflect restriction to compat1 profile
7ddfd3c 
Enforcement of scala#6164

Tested manually by reverting the sys.process.javaVmArguments change
07ff7ac and then running testJDepsImpl:

    > testJDeps
    [info] Compiling 1 Scala source to /d/scala/build/quick/classes/library...
    [info] Packaging /d/scala/build/pack/lib/scala-library.jar ...
    [info] Packaging /d/scala/build/pack/lib/scala-reflect.jar ...
    [info] Done packaging.
    [info] Done packaging.
    [trace] Stack trace suppressed: run last root/*:testJDeps for the full output.
    [error] (root/*:testJDeps) Detected dependency outside of compact1:
    [error] scala-library.jar -> /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre/lib/rt.jar (compact3)
    [error] scala-reflect.jar -> /Library/Java/JavaVirtualMachines/jdk1.8.0_144.jdk/Contents/Home/jre/lib/rt.jar (compact1)
    [error] scala-reflect.jar -> /d/scala/build/pack/lib/scala-library.jar
    [error] Total time: 4 s, completed 14-Jun-2018 14:20:02

Fixes scala/scala-dev#437
Fixes scala/bug#10559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwijnand dwijnand

Labels
enhancement t:build t:java9 t:modularize
Projects
None yet
Milestone
2.13.0-M5
Development

No branches or pull requests
2 participants
@adriaanm @dwijnand