Backport changes from 2.13 #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `sbt -Dscala.version=2.X.Y` to test out packages, newer version of sbt-git have been setting `isSnapshot` to false if there isn't a tag associated with the current commit of scala/scala-dist. This makes it hard to test out changes in this repo as we get diffs like: ``` $ rpm -qip /home/ubuntu/code/scala-dist-baseline/target/scala-2.13.6.rpm Name : scala Version : 2.13.6 Release : 1 Architecture: noarch Install Date: (not installed) Group : Development/Languages Size : 649267584 License : BSD Signature : (none) Source RPM : scala-2.13.6-1.src.rpm ``` ``` $ rpm -qip /home/ubuntu/code/scala-dist/target/scala-2.13.6.rpm Name : scala Version : 2.13.6 Release : SNAPSHOT Architecture: noarch Install Date: (not installed) Group : Development/Languages Size : 649267584 License : BSD Signature : (none) Source RPM : scala-2.13.6-SNAPSHOT.src.rpm ... ```
tested it on a branch, upload to github works now.
|
The changes and updates (sbt-native-packager in particular) could make one a little nervous, but the clean diff to 2.13.x gives me confidence. Also the artifacts built here can be fixed and replaced if something is wrong, unlike those on maven-central. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly
Diff between 2.12 with this PR and 2.13.x looks clean: https://github.com/lrytz/scala-dist/compare/merg-13..scala:scala-dist:2.13.x