Fixed NPE in VectorStepper due to dirty display vector. #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Could occur with structurally shared vectors.)
|
review by @joshlemer? |
joshlemer
reviewed
Feb 15, 2019
| public static <A> Object[] getDisplay5(scala.collection.immutable.Vector<A> v) { return v.display5(); } | ||
| public static <A> Object[] getDisplay5(scala.collection.immutable.VectorIterator<A> p) { return p.display5(); } |
There was a problem hiding this comment.
Could all these duplicates just take a scala.collection.immutable.VectorPointer<A>?
There was a problem hiding this comment.
oh I see
// (Manually specialized this way for speed.)
There was a problem hiding this comment.
Yeah, it cuts off about 20% of the runtime in my ad-hoc testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Could occur with structurally shared vectors.)
Fixed by creating an iterator, which creates a clean display. (Would probably be more efficient for everyone if this was handled a different way, but this is the easiest to code.)