Fix for issue https://issues.scala-lang.org/browse/SI-9010 #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gourlaysama can you review this PR? |
This solution takes some ideas / inspiration from the discussion in https://issues.scala-lang.org/browse/SI-4929. Added LastNoSuccessHelper object into Parsers trait to encapsulate tracking of the last NoSuccess result when tracking is actually needed. Idea is that the last NoSuccess result is only needed inside phrase parsers to give better error messages i.e. it is not needed for "correctness". Null is used as initial value for context:DynamicValue variable in LastNoSuccessHelper object as a marker if computation is outside "trackLastNoSuccessWithInitialValue" and therefore tracking of NoSuccess results is unnecessary. Tracking of NoSuccess results is done only iff computation goes trough "trackLastNoSuccessWithInitialValue", because then context variable inside LastNoSuccess helper gets None(non-null) value which enables tracking.
ghost
closed this
ghost
changed the title
|
I close this pull request and make a better one. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.