Skip to content

If class writing fails, attempt diagnoses #10791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

som-snytt
Copy link
Contributor

If class writing throws, detect certain failure modes (writing strings).

This is just a start.

@scala-jenkins scala-jenkins added this to the 2.13.15 milestone Jun 9, 2024
@som-snytt
Copy link
Contributor Author

som-snytt commented Jun 9, 2024

I didn't compile this under -Wvalue-discard.

Also neglected to check the messaging from javac.

Copy link
Member

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks! I'm not so sure what we have and what other failures are maybe somewhat common, eg with generated code. Either way, good progress.

@som-snytt som-snytt merged commit d800253 into scala:2.13.x Jun 17, 2024
3 checks passed
@som-snytt som-snytt deleted the backport/i15850-string-too-large branch June 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants