Skip to content

$outer is not marked synthetic #14083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
raboof opened this issue Dec 9, 2021 · 0 comments · Fixed by #14084
Closed

$outer is not marked synthetic #14083

raboof opened this issue Dec 9, 2021 · 0 comments · Fixed by #14084
Milestone

Comments

@raboof
Copy link
Contributor

raboof commented Dec 9, 2021

I suspect it should be, right? We're now explicitly excluding it in spray-json (https://github.com/spray/spray-json/pull/342/files#diff-02c1dfdd5a87b7d8a1793e8a95fd5ea6467c9b55c1cd942402d84ea474ee4aaaR77)

Compiler version

Any, including 3.1.0 and 3.1.2-RC1-bin-20211208-d6fe4b4-NIGHTLY

Minimized code

class Outer {
  class Inner
}

Output

$ javap -v Outer\$Inner.class
(...)
  public final Outer Outer$Inner$$$outer();
    descriptor: ()LOuter;
    flags: (0x0011) ACC_PUBLIC, ACC_FINAL

Expectation

$ javap -v Outer\$Inner.class
(...)
  public final Outer Outer$Inner$$$outer();
    descriptor: ()LOuter;
    flags: (0x1011) ACC_PUBLIC, ACC_FINAL, ACC_SYNTHETIC
odersky added a commit to dotty-staging/dotty that referenced this issue Dec 9, 2021
Fixes scala#14083

I verified manually that the puter accessors are now ACC_SYNHETIC. If someone wants to add a bytecode test, this would be good. I don't know how to make one.
odersky added a commit to dotty-staging/dotty that referenced this issue Dec 10, 2021
Fixes scala#14083

I verified manually that the puter accessors are now ACC_SYNHETIC. If someone wants to add a bytecode test, this would be good. I don't know how to make one.
olsdavis pushed a commit to olsdavis/dotty that referenced this issue Apr 4, 2022
Fixes scala#14083

I verified manually that the puter accessors are now ACC_SYNHETIC. If someone wants to add a bytecode test, this would be good. I don't know how to make one.
@Kordyjan Kordyjan added this to the 3.1.2 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants