Skip to content

-Ycheck should ensure global uniqueness of definitions #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
odersky opened this issue Oct 29, 2014 · 2 comments
Closed

-Ycheck should ensure global uniqueness of definitions #204

odersky opened this issue Oct 29, 2014 · 2 comments
Assignees
@DarkDimius

Comments

@odersky
Copy link
Contributor

odersky commented Oct 29, 2014

#203 uncovered a problem where a closure was generated twice with the same symbol. It was caught by phase RestoreScopes when the closure symbol ended up in two definitions in the scope of the enclosing class. This would have been caught earlier if -Ycheck verified that every symbol is defined only once in a compilation unit. Right now it detects only double definition in the same scope, or nested scopes.
@DarkDimius DarkDimius self-assigned this Nov 3, 2014
DarkDimius added a commit to dotty-staging/dotty that referenced this issue Nov 3, 2014
@DarkDimius
scala#204 check for global uniqueness of definitions.
f236282 
Check now fails after erasure.
Should become error after fixed.
@DarkDimius
Copy link
Contributor

f236282 implements this as warning.
It seems that there are quite a few of doubly defined symbols generated in dotty. Could be seen here: https://travis-ci.org/lampepfl/dotty/builds/39833020

DarkDimius added a commit to dotty-staging/dotty that referenced this issue Nov 17, 2014
@DarkDimius
scala#204 check for global uniqueness of definitions.
1d66a8d 
Check now fails after erasure.
Should become error after fixed.
DarkDimius added a commit to dotty-staging/dotty that referenced this issue Nov 22, 2014
@DarkDimius
scala#204 check for global uniqueness of definitions.
e935eaa 
Check now fails after erasure.
Should become error after fixed.
@smarter
Copy link
Member

smarter commented Nov 18, 2015

f236282 implements this as warning.

So can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarkDimius DarkDimius

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smarter @odersky @DarkDimius