Skip to content

Scala3doc/doc context #10568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 2, 2020
Merged

Conversation

romanowski
Copy link
Contributor

No description provided.

@romanowski romanowski force-pushed the scala3doc/doc-context branch from 9784cdb to 1447c91 Compare November 30, 2020 23:55
Copy link
Contributor

@abgruszecki abgruszecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the filename nitpick, LGTM.


import scala.collection.JavaConverters._

class NavigationCreator(using ctx: DocContext) extends PageTransformer:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in filename, should be NavigationCreator.scala

@romanowski romanowski force-pushed the scala3doc/doc-context branch from 008c9be to b135490 Compare December 1, 2020 14:27
@romanowski romanowski merged commit f1872e5 into scala:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants