Enable -Ycheck-init on community projects and CI #10627
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
safe-object-init2
branch
2 times, most recently
from
76ad797 to
38af99f
Compare
liufengyun
force-pushed
the
safe-object-init2
branch
from
38af99f to
0dd2364
Compare
liufengyun
changed the title
- Make summary a proper class - Rename isInternal to hasSource - Enable hijacking check - Refactor: remove useless parameter - Check promotion of potentials - Cache safely promoted potential - Fix test case tests/init/neg/hybrid2.scala - Split effect check into multiple methods - Refactor ignored methods handling Ignore constructor call on Any, Object and AnyVal - Add promotion tests - Fix missing return - Member promotion result override outer promotion result
Handle NoPrefix properly
Otherwise, looking up members will crash the compiler
The owners are different for the patches, and they are always safe.
Shapeless enabled `-Xfatal-warings`, the warnings make the CI fail.
liufengyun
force-pushed
the
safe-object-init2
branch
from
e1950fd to
fc339e6
Compare
|
Superseded by #11385. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable -Ycheck-init on community projects
Fix #10549
This PR is extracted from #10550. The current PR only refactors the code and does not include checking of global objects.