Fix #10174: avoid creating deep nesting union space #11058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
approved these changes
Jan 13, 2021
|
The regression test for this looks to have failed on JDK 8 in the most recent nightly CI: https://github.com/lampepfl/dotty/runs/1732363505?check_suite_focus=true |
|
It seems the test https://github.com/lampepfl/dotty/actions?query=workflow%3ADotty+event%3Aschedule Might be related to some other changes recently? |
|
I was able to reproduce locally both under Java 8 and 14. I proposed a fix in #11176. |
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 21, 2021
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10174: avoid creating deep nesting union space