Skip to content

Topic/loggable transforms #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2014

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 4, 2014

Make transforms loggable with traceIndented.

odersky added 2 commits April 4, 2014 09:57
using traceIndented in the transform method.
... to verify whether they work correctly.
@odersky
Copy link
Contributor Author

odersky commented Apr 4, 2014

@DarkDimius please review.

@odersky
Copy link
Contributor Author

odersky commented Apr 4, 2014

... and commit if OK.

@@ -1116,7 +1118,7 @@ object TreeTransforms {
case tree => tree
}

def transform(tree: Tree, info: TransformerInfo, cur: Int)(implicit ctx: Context): Tree = {
def transform(tree: Tree, info: TransformerInfo, cur: Int)(implicit ctx: Context): Tree = ctx.traceIndented(s"transforming ${tree.show} at ${ctx.phase}", transforms, show = true) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once #99 is merged, you could use i and save the .show ;-)

DarkDimius added a commit that referenced this pull request Apr 4, 2014
@DarkDimius DarkDimius merged commit 932d396 into scala:master Apr 4, 2014
@allanrenucci allanrenucci deleted the topic/loggable-transforms branch December 14, 2017 19:25
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this pull request Mar 19, 2025
Backport "(Re-)Drop inaccessible subclasses from refineUsingParent" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants