Skip to content

Recover the denotation of constant-folded selections #11373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2021

Conversation

smarter
Copy link
Member

@smarter smarter commented Feb 10, 2021

With this change, the only term selections without a symbol after Typer and before Pickler
come from polymorphic function calls or outer selects. This should be good enough to let
us use SELECTin in all situations where overloads can appear as #11210
is attempting.

@smarter smarter requested a review from bishabosha February 10, 2021 15:39
@smarter smarter changed the title Recover the denotation to constant-folded selections Recover the denotation of constant-folded selections Feb 10, 2021
@smarter smarter force-pushed the exp/tasty-symbol branch 3 times, most recently from dab4880 to 226e809 Compare February 10, 2021 16:02
With this change, the only term selections without a symbol after Typer
and before Pickler come from polymorphic function calls or outer
selects. This should be good enough to let us use SELECTin in all
situations where overloads can appear as scala#11210 is attempting.
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Yes, that should make pickling more robust.

@odersky odersky merged commit 2f91572 into scala:master Feb 11, 2021
@odersky odersky deleted the exp/tasty-symbol branch February 11, 2021 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants