Change indentation to two spaces in docs #12407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twp spaces works fine in the end, and does not require wholesale reformatting of existing code. I still believe 3 spaces looks better but it turned out to be too controversial. If we keep 3 spaces everybody will just focus on that and declare that we are crazy. So, it won't fly. if the community wants something different from 2 spaces, the community will have to argue for it and build consensus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two spaces works fine in the end, and does not require wholesale reformatting
of existing code.
I still believe 3 spaces looks better but it turned out to be too controversial.
If we keep 3 spaces everybody will just focus on that and declare that we are
crazy.
So, 3 spaces won't fly. If the community wants something different from 2 spaces, the
community will have to argue for it and build consensus.