More careful instantiation of type variables #12773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
one-instantiation-3
branch
from
41062dd to
a023600
Compare
Ensure that:
- A type variable is only instantiated once.
- A type variable instantiation is allowed given the current
constraints. This required two changes:
- In dropTransparentTrait, reset the constraints if we decide to keep
the transparent traits.
- Fix Type#simplify to preserve `=:=` (as its documentation indicate)
when dealing with skolems.
|
Ping for review. |
odersky
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that:
constraints. This required two changes:
the transparent traits.
=:=(as its documentation indicate)when dealing with skolems.