Add Automatic-Module-Names to MANIFEST.MF files of projects with suffix_3 #12903
Conversation
…ix _3 The issue is described in scala#12899 In this PR I decided to add `Automatic-Module-Name` values only to projects with the suffix _3, that is: 1. scala3-compiler_3 2. scala3-library_3 3. scala3-library-sjs1_3 4. scala3-language-server_3 5. scala3-staging_3 6. scala3-tasty-inspector_3 7. scaladoc_3 8. tasty-core_3 and for consistency also tasty-core-scala2. The values are derived from dottyOrganization + the project name.
|
Can we just do it for all projects to reduce the lines of code added to the build? |
|
@smarter : Sure, but I don't know how :) This is my first PR here. |
|
I think you could add this setting in |
project/Build.scala
Outdated
| asDottyCompiler(NonBootstrapped). | ||
| settings( | ||
| Compile / packageBin / packageOptions += | ||
| Package.ManifestAttributes("Automatic-Module-Name" -> s"$dottyOrganization-${name.value}") |
There was a problem hiding this comment.
According to https://docs.oracle.com/javase/specs/jls/se16/html/jls-7.html#jls-7.7:
A module name consists of one or more Java identifiers (§3.8) separated by "." tokens.
A java identifier can't have a - in its name, so I don't think this is a valid name, use a . instead.
There was a problem hiding this comment.
Similarly, you probably need to replaceAll("-", ".") to handle the "-" in the project names.
There was a problem hiding this comment.
Also instead of name I think we should use moduleName, that's what shows up in the pom in the end.
…all projects with commonSettings
|
Thanks, this looks fine to me but can you confirm that this solves the issue you saw with maven in #12899 ? (You can publish scala3 using |
Sorry. Yesterday I only had time to make the update. Yes, I tested it with the project I mentioned in the issue and the warning is gone now. By the way, I have never had any problems with the '-' character in the automatic module name, but okay, replacing it with '.' shouldn't hurt. |
|
There is some discussion about split packages at https://users.scala-lang.org/t/gradle-7-6-jdk-19-and-scala-3-java-lang-classnotfoundexception-scala-predef-even-though-scala-library-2-13-10-jar-is-in-classpath/8972 |
The issue is described in #12899
In this PR I decided to add
Automatic-Module-Namevalues only to projects with the suffix _3, that is:and for consistency also tasty-core-scala2. The values are derived from dottyOrganization + the project name.