Skip to content

Fixed #143 #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2014
Merged

Fixed #143 #145

merged 2 commits into from
Jul 19, 2014

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jul 19, 2014

The problem was that TermRefWithSignatures did not take shadowed names into account
when reconstituting themselves under a new prefix. review by @DarkDimius.

odersky added 2 commits July 19, 2014 11:31
The problem was that TermRefWithSignatures did not take shadowed names into account
when reconstituting themselves under a new prefix.
@DarkDimius
Copy link
Contributor

Why is test in pending? AFAIK tests in pending aren't run.

@DarkDimius
Copy link
Contributor

Otherwise LGTM after tests pass.

odersky added a commit that referenced this pull request Jul 19, 2014
@odersky odersky merged commit 1f6f667 into scala:master Jul 19, 2014
@allanrenucci allanrenucci deleted the fix/#143 branch December 14, 2017 19:21
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this pull request Mar 19, 2025
Backport "Fix scala#21619: Refactor NotNullInfo to record every reference which is retracted once." to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants