Handle Block and If in BCodeBodyBuilder.genCond().
#15081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `Block`s, we can push `genCond` inside the final `expr`, reducing the number of cases where we need to go through `loadAndTestBoolean`. This is particularly effective for the shape of `do..while` loops, as shown in the changed test.
This is more for completeness of `genCond()`. It can now push down the jumps inside all the control structures for which it makes sense to do so. It typically applies when the condition of an `if` or `while` is an `if..else` expression. It is however not always a win. If the result of the nested `if`s must be converted to a boolean anyway, doing this will result in duplication of the conversion to boolean. A jardiff on the bootstrapped `scala3-compiler.jar` shows 191 additions and 287 deletions, suggesting that, on average, this is good to have.
lrytz
approved these changes
May 2, 2022
|
Thanks for the reviews. :) |
This was referenced May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are my last suggestions for a better codegen by construction. The first one, for
Block, is always a win. The second one is sometimes a bit worse, as mentioned in the commit message.For reference, the whole
scala3-compiler.jarjardiff for the second commit can be seen here:https://gist.github.com/sjrd/9ec0f9f53308fb8c8c747f4bd0e480f7