Skip to content

fix quick-links, fix doc layout #15911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented Aug 25, 2022

corrects the fixes the reference documentations layout to be correct with the new docs ui.

@pikinier20 I'm not sure if the reference documentation will still be rendered with the old ui, so could there be an issue with changing the layout?, what is your advice?

@julienrf
Copy link
Contributor

julienrf commented Oct 6, 2022

@bishabosha Could you please post a screenshot showing the new layout?
@pikinier20 Could you please tell us how to check that the rendering of the reference documentation is still correct?

@bishabosha bishabosha removed the request for review from pikinier20 October 6, 2022 12:53
@bishabosha
Copy link
Member Author

now the reference docs have published, this PR is needed, e.g. you see the "quick links" are put on the page twice at https://docs.scala-lang.org/scala3/reference/:

Screenshot 2022-11-08 at 15 16 34

@bishabosha
Copy link
Member Author

seems also that #15912 needs to be backported to stable docs

@bishabosha bishabosha changed the base branch from main to language-reference-stable November 8, 2022 15:33
@bishabosha bishabosha closed this Nov 8, 2022
@bishabosha bishabosha force-pushed the fix-reference-docs-layout branch from 732de1f to ae0c926 Compare November 8, 2022 15:43
@julienrf julienrf deleted the fix-reference-docs-layout branch November 8, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants