Skip to content

Skip caching provisional OrType atoms #16295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dwijnand
Copy link
Member

@dwijnand dwijnand commented Nov 7, 2022

Also, fix printing TypeVars when not using -Yprint-debug so that it
doesn't add redudant and misleading parentheses, which can lead to the
perception that a tuple was inferred.

@dwijnand dwijnand linked an issue Nov 7, 2022 that may be closed by this pull request
Also, fix printing TypeVars when not using -Yprint-debug so that it
doesn't add redudant and misleading parentheses, which can lead to the
perception that a tuple was inferred.
@dwijnand dwijnand force-pushed the OrType-atoms-caching-and-TypeVar-printing branch from 63c21ff to 7546867 Compare November 7, 2022 17:41
@dwijnand dwijnand marked this pull request as ready for review November 7, 2022 19:07
@dwijnand dwijnand requested a review from odersky November 7, 2022 19:08
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odersky odersky merged commit b5941e4 into scala:main Nov 8, 2022
@dwijnand dwijnand deleted the OrType-atoms-caching-and-TypeVar-printing branch November 8, 2022 17:49
@Kordyjan Kordyjan added this to the 3.3.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected tuple inferred from dependent typing as an error
3 participants