Skip to content

Remainder of the Spec updates about removals #16841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 1, 2023
Merged

Conversation

Sporarum
Copy link
Contributor

@Sporarum Sporarum commented Feb 6, 2023

This is the rest of the work I did on the Spec, it is not in individual PRs, but still follows the other principles outlined in #16839 and in docs/_spec/README.md

Sporarum added 13 commits April 28, 2023 09:35
As Scala 2 macros were an experimental feature,
they were not included in the spec,
and the macro keyword is still a keyword
there is thus nothing to do
(Scala 3 macros  will get their own commits through the corresponding pages)
Scala 3 does not infer more precise types for the return type of overriding methods.
This can be seen in the following example:
```scala
type T
type U <: T

abstract class A{
	def m: T
}
class B extends A{
	def m = ??? : U
}
val res: U = (new B).m
```
As the feature is not actually deprecated, no changes to the spec are needed
Will make it easier to explain later what happens when you apply a using method to explicit parameters
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed this PR commit by commit and commented on what needs to be done before we can merge it.

effort to approximate existential types with its own types. It will
issue a warning that a precise emulation is not possible.

### Procedure Syntax
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that section should be dropped from the spec, IMHO it belongs to the migration guide.

@sjrd
Copy link
Member

sjrd commented Apr 28, 2023

@julienrf Did you intentionally push the "Wildcard Types" commit to this PR branch?

@julienrf
Copy link
Contributor

Yes, I wanted to shape this PR to a mergeable state.

@sjrd sjrd marked this pull request as ready for review April 28, 2023 15:37
@sjrd
Copy link
Member

sjrd commented Apr 28, 2023

I believe this ready for merging now. @julienrf do you agree?

@sjrd sjrd requested a review from julienrf May 1, 2023 08:36
@sjrd sjrd changed the title Remainder of the Spec updates Remainder of the Spec updates about removals May 1, 2023
@sjrd sjrd merged commit 2a1e3de into scala:main May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants