Simplify QuoteMatcher.&&& using optional
#16953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
simplify-quote-matcher
branch
from
37ba334 to
8aacc89
Compare
odersky
reviewed
Feb 27, 2023
| @@ -121,19 +117,20 @@ object QuoteMatcher { | |||
|
|
|||
| private def withEnv[T](env: Env)(body: Env ?=> T): T = body(using env) | |||
|
|
|||
| def treeMatch(scrutineeTree: Tree, patternTree: Tree)(using Context): Option[Tuple] = | |||
| def treeMatch(scrutineeTree: Tree, patternTree: Tree)(using Context): Option[Seq[Expr[Any]]] = | |||
There was a problem hiding this comment.
Maybe make a type alias for Seq[Expr[Any]] and explain how it is used in a doc comment for it?
There was a problem hiding this comment.
I added type MatchingExprs with its documentation.
nicolasstucki
force-pushed
the
simplify-quote-matcher
branch
from
8aacc89 to
a57e749
Compare
nicolasstucki
force-pushed
the
simplify-quote-matcher
branch
from
a57e749 to
dbdca17
Compare
|
This commit is now included in #16951. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
optionalboundary abstraction inQuoteMatcher. Specifically to reduce the syntactic and runtime overhead of&&&. For this we defineoptionalin the compiler utils to make it available in the compiler.Also, use
Seqconcatenation instead ofTupleconcatenation to have the types of elements.