Inline traits numeric example #17098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods missing in the skeleton Add given for all primitive types Add test methods for division, modulo, sign and toInt
Create version of InlineNumeric that extends Numeric. This requires:
- dropping the inline keyword for parameters (cannot override non-inline
parameter with inline parameter)
- dropping abs, sign, zero and one from InlineNumeric (see code for the
errors). Instead, override them in the given instances
Create version of InlineNumeric with extension methods defined in
the traits instead of in the companion objects.
This allows the usage of said methods without having to import them.
The inconvenient is that the overriding must be done with extension
methods, but since an extension method
object A:
extension (x: T)
def foo: U = ???
can be called both like x.foo and A.foo(x), this allows for both forms
when performing operations such as toInt.
Split code into separate files for clarity Reimplement Numeric and Ordering as inline Place symbols in the trait
nicolasstucki
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite of the Numeric library. This new version uses inlining to improve performance on basic numeric operations.