Skip to content

Make the weak-conformance test work on Scala.js. #17656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions tests/run/weak-conformance.scala
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// scalajs: --skip --pending

import collection.mutable.ArrayBuffer
object Test extends App {
inline val b = 33
Expand All @@ -16,11 +14,11 @@ object Test extends App {
val x8 = List(5.toByte, 11) ; x8: List[Byte]

val x9: List[AnyVal] = List(1.0f, 0)
assert(x9(0).getClass == classOf[java.lang.Float])
assert(x9(1).getClass == classOf[java.lang.Float]) // expected type not fully defined, since `List` is covariant
assert(x9(0).isInstanceOf[java.lang.Float])
assert(x9(1).isInstanceOf[java.lang.Float]) // expected type not fully defined, since `List` is covariant
val x10 = List[Any](1.0f, 0)
assert(x10(0).getClass == classOf[java.lang.Float])
assert(x10(1).getClass == classOf[java.lang.Integer])
assert(x10(0).isInstanceOf[java.lang.Float])
assert(x10(1).isInstanceOf[java.lang.Integer])
}

locally {
Expand All @@ -35,11 +33,11 @@ object Test extends App {
val x8 = ArrayBuffer(5.toByte, 11) ; x8: ArrayBuffer[Byte]

val x9: ArrayBuffer[AnyVal] = ArrayBuffer(1.0f, 0)
assert(x9(0).getClass == classOf[java.lang.Float])
assert(x9(1).getClass == classOf[java.lang.Integer]) // expected type fully defined since ArrayBuffer is nonvariant
assert(x9(0).isInstanceOf[java.lang.Float])
assert(x9(1).isInstanceOf[java.lang.Integer]) // expected type fully defined since ArrayBuffer is nonvariant
val x10 = ArrayBuffer[Any](1.0f, 0)
assert(x10(0).getClass == classOf[java.lang.Float])
assert(x10(1).getClass == classOf[java.lang.Integer])
assert(x10(0).isInstanceOf[java.lang.Float])
assert(x10(1).isInstanceOf[java.lang.Integer])
}

locally {
Expand All @@ -56,11 +54,11 @@ object Test extends App {
val x8 = Array(5.toByte, 11) ; x8: Array[Int]

val x9: Array[AnyVal] = Array(1.0f, 0)
assert(x9(0).getClass == classOf[java.lang.Float])
assert(x9(1).getClass == classOf[java.lang.Integer]) // expected type fully defined since Array is nonvariant
assert(x9(0).isInstanceOf[java.lang.Float])
assert(x9(1).isInstanceOf[java.lang.Integer]) // expected type fully defined since Array is nonvariant
val x10 = Array[Any](1.0f, 0)
assert(x10(0).getClass == classOf[java.lang.Float])
assert(x10(1).getClass == classOf[java.lang.Integer])
assert(x10(0).isInstanceOf[java.lang.Float])
assert(x10(1).isInstanceOf[java.lang.Integer])
}

locally {
Expand All @@ -74,4 +72,4 @@ object Test extends App {
val x7 = if (true) b else if (true) 33 else 'a' ; x7: Char
val x8 = if (true) 5.toByte else 11 ; x8: Byte
}
}
}