Skip to content

Spec: Apply changes to weak conformance and introduce harmonization. #17942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Jun 7, 2023

[skip ci]

Note that weak conformance was not entirely dropped. It is still applicable to determine compatibility of a method call argument to the parameter type. See #7708.

@odersky Since you asked about it in the big type system PR. ;) FYI the changes in TODOreference and APPLIEDreference are part of our process to integrate the Reference into the Spec.

@sjrd sjrd requested a review from odersky June 7, 2023 13:46
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@@ -1,54 +0,0 @@
---
layout: doc-page
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's valuable to have precise rules in these pages or at least refer to them. Of course, many pages here do not have precise rules, but I'd like us to move in the general direction of more precise rules, not loss.

So I'd either keep this page, or link to the section on Harmonization in the spec, if that's feasible.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't publish the spec yet, so I cannot link to it. But I re-introduced an explicit reference to the relevant sections of the spec. (note that the content of APPLIEDreference is not what gets published at https://docs.scala-lang.org/scala3/reference/ at the moment, so this does not change anything to the currently published documents).

@odersky odersky assigned sjrd and unassigned odersky Jun 16, 2023
Note that weak conformance was not entirely dropped. It is still
applicable to determine *compatibility* of a method call argument
to the parameter type.
@sjrd sjrd force-pushed the spec-harmonization branch from bc1e59a to 3f3423f Compare June 16, 2023 08:59
@sjrd sjrd requested a review from odersky June 16, 2023 09:00
@sjrd sjrd assigned odersky and unassigned sjrd Jun 16, 2023
@sjrd
Copy link
Member Author

sjrd commented Jun 20, 2023

Ping @odersky. Is this OK to merge?

@odersky
Copy link
Contributor

odersky commented Jun 20, 2023

Yes, ready to merge.

@odersky odersky merged commit 6087911 into scala:main Jun 20, 2023
@sjrd sjrd deleted the spec-harmonization branch June 20, 2023 08:25
Kordyjan added a commit that referenced this pull request Dec 8, 2023
…nization." to LTS (#19027)

Backports #17942 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
@Kordyjan Kordyjan added this to the 3.3.2 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants