-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Spec: Apply changes to weak conformance and introduce harmonization. #17942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
@@ -1,54 +0,0 @@ | |||
--- | |||
layout: doc-page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's valuable to have precise rules in these pages or at least refer to them. Of course, many pages here do not have precise rules, but I'd like us to move in the general direction of more precise rules, not loss.
So I'd either keep this page, or link to the section on Harmonization in the spec, if that's feasible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't publish the spec yet, so I cannot link to it. But I re-introduced an explicit reference to the relevant sections of the spec. (note that the content of APPLIEDreference
is not what gets published at https://docs.scala-lang.org/scala3/reference/ at the moment, so this does not change anything to the currently published documents).
Note that weak conformance was not entirely dropped. It is still applicable to determine *compatibility* of a method call argument to the parameter type.
Ping @odersky. Is this OK to merge? |
Yes, ready to merge. |
[skip ci]
Note that weak conformance was not entirely dropped. It is still applicable to determine compatibility of a method call argument to the parameter type. See #7708.
@odersky Since you asked about it in the big type system PR. ;) FYI the changes in
TODOreference
andAPPLIEDreference
are part of our process to integrate the Reference into the Spec.