chore: get rid of legacy e2e directory #17960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So these haven't been touched in over 3 years and are very outdated. With the update to the new scaladoc UI refactor, these were never updated. They also don't seem to be actual testing a lot apart from the old filter bar. Looking at the comment [here](scala#17401 (reply in thread)), I agree that it's probably best to just sunset this. If someone really wants to dig into this in the future they can look back at these, but I think to avoid any confusion we should just remove these. [skip test] [skip test_windows_fast] [skip mima] [skip community_build] [skip test_sbt]
Florian3k
approved these changes
Jun 13, 2023
Kordyjan
pushed a commit
that referenced
this pull request
Nov 17, 2023
So these haven't been touched in over 3 years and are very outdated. With the update to the new scaladoc UI refactor, these were never updated. They also don't seem to be actual testing a lot apart from the old filter bar. Looking at the comment [here](#17401 (reply in thread)), I agree that it's probably best to just sunset this. If someone really wants to dig into this in the future they can look back at these, but I think to avoid any confusion we should just remove these. [skip test] [skip test_windows_fast] [skip mima] [skip community_build] [skip test_sbt] refs: #17401 [Cherry-picked d332059]
Kordyjan
added a commit
that referenced
this pull request
Nov 21, 2023
Backports #17960 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So these haven't been touched in over 3 years and are very outdated. With the update to the new scaladoc UI refactor, these were never updated. They also don't seem to be actual testing a lot apart from the old filter bar. Looking at the comment
here, I agree that it's probably best to just sunset this. If someone really wants to dig into this in the future they can look back at these, but I think to avoid any confusion we should just remove these.
[skip test]
[skip test_windows_fast]
[skip mima]
[skip community_build]
[skip test_sbt]
refs: #17401