Java parses leading annotation #20064
Conversation
| if in.token == PACKAGE then | ||
| if !leadingAnnots.isEmpty then | ||
| //if (unit.source.file.name != "package-info.java") | ||
| // syntaxError(pos, "package annotations must be in file package-info.java") |
There was a problem hiding this comment.
not sure scalac needs to enforce this javac rule if the annotations are not used
There was a problem hiding this comment.
I think generally we don't add code to enforce Java rules that don't affect us in any way.
som-snytt
force-pushed
the
issue/20026-java-parse
branch
from
9fca170 to
637e421
Compare
|
|
||
| object Test extends App { | ||
| println { | ||
| new JTest |
There was a problem hiding this comment.
(same remark as in scala 2) add reference to JFun and KTest?
| if in.token == PACKAGE then | ||
| if !leadingAnnots.isEmpty then | ||
| //if (unit.source.file.name != "package-info.java") | ||
| // syntaxError(pos, "package annotations must be in file package-info.java") |
There was a problem hiding this comment.
I think generally we don't add code to enforce Java rules that don't affect us in any way.
|
Drafting to forward port the related annotations commits from Scala 2. |
|
@som-snytt I've merged the Scala 2 one. Does this one need to be updated or is it ready to go? |
|
@SethTisue I assume there is more annotations work to forward port, but I haven't had a chance (will) to look at it. Undrafting because it fixes something. I guess a solar eclipse can result in either a burst of productivity or a shadowed malaise. |
Motivated by #20026