Skip to content

Refactor adaptBoxed #20525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

Refactor adaptBoxed #20525

merged 1 commit into from
Jun 5, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jun 5, 2024 •
edited
Loading

  • Factor out common decomposition and re-composition methods.
  • Try to make names more informative

@odersky odersky requested a review from Linyxus June 5, 2024 09:42
Linyxus
Linyxus approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@Linyxus Linyxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect alwaysConst could be dropped: now it seems that we always constantise the capture set. But this could be worked out in another PR. LGTM!

@odersky odersky merged commit 746b00b into scala:main Jun 5, 2024
@odersky odersky deleted the refactor-adaptBoxed branch June 5, 2024 13:50
@odersky
Copy link
Contributor Author

odersky commented Jun 5, 2024

In fact, I just tried. We can't drop alwaysConst. Quite a few tests would fail. We do constify in adaptShape though.

@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linyxus Linyxus Linyxus approved these changes

Assignees

@Linyxus Linyxus

Labels
None yet
Projects
None yet
Milestone
3.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@odersky @Linyxus @Kordyjan