Warn if interpolator uses toString #20578
Conversation
som-snytt
force-pushed
the
port/warn-toString
branch
from
68521a8 to
e788f89
Compare
|
The Scala 2 version of this will ship very soon (in 2.13.15). |
|
@som-snytt may I ask you why did you close this pr? I would love to use this flag 🙏 |
som-snytt
force-pushed
the
port/warn-toString
branch
from
a2ebaa0 to
941615f
Compare
compiler/src/dotty/tools/dotc/transform/localopt/FormatChecker.scala
Outdated
Show resolved
Hide resolved
compiler/src/dotty/tools/dotc/transform/localopt/FormatChecker.scala
Outdated
Show resolved
Hide resolved
| case _ => true | ||
|
|
||
| def lintToString(arg: Type): Unit = | ||
| if ctx.settings.Whas.toStringInterpolated && kind == StringXn && !(arg.widen =:= defn.StringType) && !arg.isPrimitiveValueType | ||
| then warningAt(CC)("interpolation uses toString") |
There was a problem hiding this comment.
This would probably be better, when done as a separate PR, but it might be useful to add message ids for all the error/warning messages in this file.
som-snytt
force-pushed
the
port/warn-toString
branch
from
941615f to
6fc84a6
Compare
|
I took the suggestions, and added an error ID and kind for the messages, which look better that way. (Such a small change to make such a big difference.) (Probably There are too many specific messages for more granularity. Also minor refactoring or formatting for readability. Some of the long one-liners look like it's trying to save paper for a print-out. |
som-snytt
force-pushed
the
port/warn-toString
branch
2 times, most recently
from
295bcc9 to
d96843b
Compare
som-snytt
force-pushed
the
port/warn-toString
branch
from
d96843b to
ba4204e
Compare
Ports scala/scala#10776
"I always forget how to use Scala 3."