fix for #22443: prevent stty from being called when not running in a terminal #22444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
reviewed
Mar 9, 2025
| # clear on error so we don't later try to restore them | ||
| if [[ ! $? ]]; then | ||
| saved_stty="" | ||
| if [ -e /usr/bin/tty -a "`tty`" != "not a tty" -a ! -p /dev/stdin ]; then |
There was a problem hiding this comment.
I checked and played a bit with the locale and it seems that tty will always output 'not a tty' regardless of the current locale. Which means that we can rely on that output being in the same language.
% date
Sun Mar 9 14:58:45 CET 2025
% tty < /dev/null
not a tty
% export LANG=fr_FR.UTF-8
% date
Dim 9 mar 2025 14:59:00 CET
% tty < /dev/null
not a tty| saved_stty=$(stty -g 2>/dev/null) | ||
| # clear on error so we don't later try to restore them | ||
| if [[ ! $? ]]; then | ||
| saved_stty="" |
There was a problem hiding this comment.
Here you clear the cached stty but you don't clear the isterminal variable. The code below will try to recover the stty if isterminal is set to 1. Locally, recovering the stty with these parameters might be problematic:
% stty
speed 9600 baud;
lflags: echoe echoke echoctl pendin
iflags: iutf8
oflags: -oxtabs
cflags: cs8 -parenb
% stty ""
stty: illegal option --
usage: stty [-a | -e | -g] [-f file] [arguments]There was a problem hiding this comment.
good point. Clearing isterminal when stty is cleared seems correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test whether running in a terminal, and only call
sttyif appropriate.This avoids seeing
sttyerror messages when piping text to a scala scriptSTDIN.Closes #22443