Skip to content

Fix #2220: disable benchmarks, set run timeout to 30 seconds #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 13, 2017

Conversation

felixmulder
Copy link
Contributor

Not sure if this is too aggressive. I'd like some input.

@smarter
Copy link
Member

smarter commented Apr 13, 2017

Probably too aggressive if we want the tests to succeed under high load. I would put 30 seconds to have a good margin.

@felixmulder
Copy link
Contributor Author

I actually ran this successfully multiple times without failure on my machine with 3 seconds timeout.

Do you think we still need 10x that for the CI?

@smarter
Copy link
Member

smarter commented Apr 13, 2017

Try running something which uses 100% of all your cores on your machine at the same time.

@felixmulder felixmulder changed the title Fix #2220: disable benchmarks, set run timeout to 10 seconds Fix #2220: disable benchmarks, set run timeout to 30 seconds Apr 13, 2017
@felixmulder
Copy link
Contributor Author

Alright 30 it is ^^

@smarter
Copy link
Member

smarter commented Apr 13, 2017

Some of the disabled tests are not benchmarks but stress tests for the collection, so the directory name is not correct for them, but I agree that they should be disabled. However I don't see why Course-2002-04.scala should be disabled, it looks like a legitimate test to me.

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@felixmulder
Copy link
Contributor Author

@smarter - done, renamed the dir to long-running instead. That's perhaps more apt.

@smarter
Copy link
Member

smarter commented Apr 13, 2017

I still think Course-2002-04.scala should not be disabled. How long does it take? Why does it take that long?

@felixmulder
Copy link
Contributor Author

@smarter - my mistake. Didn't think that I'd already moved it to disabled.

@felixmulder
Copy link
Contributor Author

@smarter - does it have your blessing now?

Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@felixmulder felixmulder merged commit 975f7ef into scala:master Apr 13, 2017
@felixmulder felixmulder deleted the fix-#2220 branch April 13, 2017 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants