-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix #2220: disable benchmarks, set run timeout to 30 seconds #2251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Probably too aggressive if we want the tests to succeed under high load. I would put 30 seconds to have a good margin. |
I actually ran this successfully multiple times without failure on my machine with 3 seconds timeout. Do you think we still need 10x that for the CI? |
Try running something which uses 100% of all your cores on your machine at the same time. |
Alright 30 it is ^^ |
Some of the disabled tests are not benchmarks but stress tests for the collection, so the directory name is not correct for them, but I agree that they should be disabled. However I don't see why Course-2002-04.scala should be disabled, it looks like a legitimate test to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
@smarter - done, renamed the dir to |
I still think Course-2002-04.scala should not be disabled. How long does it take? Why does it take that long? |
@smarter - my mistake. Didn't think that I'd already moved it to disabled. |
@smarter - does it have your blessing now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Not sure if this is too aggressive. I'd like some input.