Fix setup of class constructors #22980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fox the containsCovarRetains criterion that decides when to make a parameter not provate for the purposes of capture checking. We were missing a dealias, so `A => B` was not detected to contain a capture set. Also avoid refining with the same name twice in inferred types.
odersky
force-pushed
the
fix-cc-class-setup
branch
from
4d81484 to
37c52ad
Compare
natsukagami
approved these changes
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the containsCovarRetains criterion that decides when to make a parameter not private for the purposes of capture checking. We were missing a dealias, so
A => Bwas not detected to contain a capture set.Also avoid refining with the same name twice in inferred types.