Skip to content

Tighten condition to preserve denotation in IntegrateMap #23060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
+24 −2
Merged

Tighten condition to preserve denotation in IntegrateMap #23060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions compiler/src/dotty/tools/dotc/core/Types.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3858,8 +3858,12 @@ object Types extends TypeUtils {

override final def derivedSelect(tp: NamedType, pre: Type): Type =
if tp.prefix eq pre then tp
else if tp.symbol.exists then NamedType(pre, tp.name, tp.denot.asSeenFrom(pre))
else NamedType(pre, tp.name)
else
pre match
case ref: ParamRef if (ref.binder eq self) && tp.symbol.exists =>
NamedType(pre, tp.name, tp.denot.asSeenFrom(pre))
case _ =>
tp.derivedSelect(pre)

final def derivedLambdaType(paramNames: List[ThisName] = this.paramNames,
paramInfos: List[PInfo] = this.paramInfos,
Expand Down
18 changes: 18 additions & 0 deletions tests/pos/23056.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
def Test = {
val ops: CompileOps[Option, Option, Any] = ???
ops.to(List).map(_.reverse) // error
}

trait CompileOps[F[_], G[_], O]:
def to(collector: Collector[O]): G[collector.Out]
trait Collector[-A] {
type Out
}

object Collector:
type Aux[A, X] = Collector[A] { type Out = X }

given [A, C[_]]: Conversion[
scala.collection.IterableFactory[C],
Collector.Aux[A, C[A]]
] = ???
Loading