Script for running compiler outside sbt #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@VladUreche @lrytz please review. |
| # autodetecting the compiler jar. this is location where sbt 'packages' it | ||
| MAIN_JAR=$MY_PATH/target/scala-$SCALA_VERSION/dotty_$SCALA_VERSION-$DOTTY_VERSION-SNAPSHOT.jar | ||
|
|
||
| # Autodetecling scala-library, in case it wasn't provided by environmen variable |
|
@DarkDimius: I will review tonight, GTG. |
| echo "The required jar file has not been built by sbt. Please run \"sbt $2\"" | ||
| exit 1 | ||
| else | ||
| echo "The required jar file was built." |
|
@DarkDimius, can you clean up the references to |
|
|
||
|
|
||
| # Try to autodetect real location of the script | ||
| DOTTY_ROOT="`readlink \"$0\"`" # relative, symbolic links resolved |
There was a problem hiding this comment.
@DarkDimius, can you please add a guard against the machine missing readlink? It should be something like:
if [ -z `which readlink` ]; then
echo "Please install readlink: {brew, apt-get, yum} install readlink"
exit 1
fi
There was a problem hiding this comment.
In Gentoo, Debian and Fedora readlink is actually provided by coreutils.
Which distributive\OS are you running?
There was a problem hiding this comment.
Oh, sorry, I had reallink in mind. My bad, readlink is part of the coreutils.
|
LGTM with the latest changes. |
VladUreche
pushed a commit
that referenced
this pull request
Feb 20, 2014
Script for running compiler outside sbt
19 tasks
noti0na1
added a commit
to noti0na1/dotty
that referenced
this pull request
Sep 27, 2019
* ValDefInBlockCompleter is replaced by general Completer * Let flow typing work for all definitions (DefDef and ValDef) in methods * Disable flow typing when forward references exist * Modify tests
pikinier20
added a commit
that referenced
this pull request
Aug 16, 2022
Repair tests. Few css fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10 for discussion