Fix #2809: Invalidate and unlink symbols for artifact classfiles #2830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
force-pushed
the
fix-complete-scala
branch
3 times, most recently
from
0fc8632 to
8aa02c0
Compare
|
Ping @odersky, this might be nice to get in the release. |
odersky
reviewed
Jul 11, 2017
| if (scan(tpnme.ScalaATTR) && !scalaUnpickleWhitelist.contains(classRoot.name)) { | ||
| // If the Scala attribute is present but the TASTY attribute isn't, this | ||
| // classfile is a compilation artifact. | ||
| return Some(NoEmbedded) |
There was a problem hiding this comment.
Don't understand the logic here, What is the significance of ScalaATTR? What happens with Scala2 classfiles?
| val boundaryCtx = ctx.withOwner(boundary) | ||
| prefix.memberDenots(completionsFilter, (name, buf) => | ||
| buf ++= prefix.member(name).altsWith(_.symbol.isAccessibleFrom(prefix)(boundaryCtx)) | ||
| buf ++= prefix.member(name).altsWith(d => !d.isAbsent && d.symbol.isAccessibleFrom(prefix)(boundaryCtx)) |
There was a problem hiding this comment.
Is there are way both isAbsent and isAccessibleFrom can be true? Should there be?
smarter
force-pushed
the
fix-complete-scala
branch
from
8aa02c0 to
07fa44e
Compare
This is similar to scala/scala#5952, we do not need to parse artifact classfiles (that is, classfiles produced by scalac or dotty that do not contain pickling information), so we discard them as soon as possible. This fixes various IDE crashes when trying to complete packages such as "scala."
smarter
force-pushed
the
fix-complete-scala
branch
from
07fa44e to
77b247d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.