Fix #1463: no type cast in singelton equality test #2988
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Aug 16, 2017
|
|
||
| def f0(x: Any) = x match { case Bob2 => Bob2 } // class cast exception at runtime, dotc only | ||
| def f1(x: Any) = x match { case Bob => Bob } // class cast exception at runtime, dotc only | ||
| def f2(x: Any): Bob.type = x match { case x @ Bob => x } // class cast exception at runtime, dotc and javac. |
There was a problem hiding this comment.
This should not typecheck because x in the right hand side should have type Any, not Bob.type, as explained in my comment: #1463 (comment)
This matches the behavior of scalac with -Xfuture.
liufengyun
force-pushed
the
fix-1463
branch
2 times, most recently
from
e5f0709 to
f2b453a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1463: no type cast in singelton equality test