Fix #2967: Adapt Vulpix, InteractiveDriver to SAM types #3010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rajesh-Veeranki - could you sign the Scala CLA so that we can accept the code :) It's available here: https://www.lightbend.com/contribute/cla/scala |
|
When you feel done, please ping me and @smarter for review 👍 |
3shv
changed the title
|
Signed the CLA. I feel it's done. Please have a look |
|
Will give it a look first thing in the morning, sleepy time 💤 Thanks for the PR! |
smarter
reviewed
Aug 23, 2017
| @@ -123,16 +123,11 @@ class InteractiveDriver(settings: List[String]) extends Driver { | |||
| // Like in `ZipArchiveFileLookup` we assume that zips are immutable | |||
| private val zipClassPathClasses: Seq[String] = zipClassPaths.flatMap { zipCp => | |||
| // Working with Java 8 stream without SAMs and scala-java8-compat is awful. | |||
There was a problem hiding this comment.
You can remove that comment now :).
|
It should also be possible to use a SAM here now: https://github.com/lampepfl/dotty/blob/master/language-server/src/dotty/tools/languageserver/DottyLanguageServer.scala#L139 |
3shv
force-pushed
the
fix-2967
branch
2 times, most recently
from
04ed0d1 to
9a63bec
Compare
allanrenucci
force-pushed
the
fix-2967
branch
from
9a63bec to
3e70adf
Compare
|
Blocked by #2732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.