Add an error message class for a case where a trait is expected #3465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
approved these changes
Nov 13, 2017
allanrenucci
suggested changes
Nov 13, 2017
| """class A | ||
| |class B | ||
| | | ||
| |val a = new A with B // will fail with a compile error - B is not a trait""" |
There was a problem hiding this comment.
You should stripMargin here
| """class A | ||
| |trait B | ||
| | | ||
| |val a = new A with B // compiles normally""" |
There was a problem hiding this comment.
You should stripMargin here
| @@ -1888,4 +1888,32 @@ object messages { | |||
| } | |||
| val explanation = "A statement is either an import, a definition or an expression." | |||
| } | |||
|
|
|||
| case class TraitIsExpected(tref: TypeRef)(implicit ctx: Context) extends Message(TraitIsExpectedID) { | |||
There was a problem hiding this comment.
I would rather pass the symbol instead of the TypeRef
|
@allanrenucci all done. PTAL. |
allanrenucci
approved these changes
Nov 13, 2017
|
It seems that the CLA check is still pending. Is there anything I can do to make it pass? 😟 |
nicolasstucki
approved these changes
Nov 14, 2017
|
Sometimes the CLA stalls |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #1589. Specifically, it adds a new error message class for the following case -
Checking.scala:551