Fix #3647: Define topLevelClass for NoDenotation #3717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Dec 31, 2017
| @@ -925,7 +925,7 @@ object SymDenotations { | |||
| /** The top-level class containing this denotation, | |||
| * except for a toplevel module, where its module class is returned. | |||
| */ | |||
| final def topLevelClass(implicit ctx: Context): Symbol = { | |||
| def topLevelClass(implicit ctx: Context): Symbol = { | |||
There was a problem hiding this comment.
Why not do if (!exists) symbol instead of adding an override? That's more consistent with other definitions in this class like lexicallyEnclosingClass
There was a problem hiding this comment.
Agreed, I'll change it.
allanrenucci
reviewed
Jan 1, 2018
| if (d.isEffectiveRoot || (d is PackageClass) || (d.owner is PackageClass)) d.symbol | ||
| else topLevel(d.owner) | ||
| } | ||
| def topLevelClass(implicit ctx: Context): Symbol = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.