Refactor inhabited in exhaustivness check
#3888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBlanvillain
approved these changes
Jan 26, 2018
There was a problem hiding this comment.
Code LGTM, @liufengyun could you give an intuition of why you need to compute this conjunctive normal form?
| val tp1 = cnf(tp) | ||
| val l1 = cnf(l) | ||
| val r1 = cnf(r) | ||
| OrType(cnf(AndType(l1, tp1)), cnf(AndType(r1, tp1))) |
There was a problem hiding this comment.
I think you don't need to compute cnf(l), cnf(r) and cnf(tp) here, it's already handled by the recursion, the body of this case could be changed to the following:
OrType(cnf(AndType(l, tp)), cnf(AndType(r, tp)))There was a problem hiding this comment.
You are right, good catch.
|
@OlivierBlanvillain The motivation for CNF is to ease employing the facts of "single inheritance" and "final class". For checks that employ the fact about "singleton types", CNF is not required. |
liufengyun
force-pushed
the
refactor-inhabited
branch
from
6facaca to
7799da6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there is both
implementabilityandinhabited. The refactoring merges the two and simplify the logic.