Fix #2732: Allow wildcards in SAM types (take 2) #4152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narrowing the type is not necessary to check for instantiability, and it prevents valid SAM types with wildcards from being used. This commit does not contain any positive testcase because SAM types with wildcards need another fix present in the next commit to work.
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4152/ to see the changes. Benchmarks is based on merging with master (0c5e39d) |
odersky
approved these changes
Mar 23, 2018
| // | ||
| // the single abstract method will have type: | ||
| // | ||
| // (x: Function[_ >: String, _ <: Int]#T): Function[_ >: String, _ <: Int]#R |
There was a problem hiding this comment.
Is that really its type? By what means was that computed? I would have thought that it's unsound to assume the argument type as written.
There was a problem hiding this comment.
That's the type I saw, it comes from tp.abstractTermMembers above where tp is an AppliedType, I guess this cannot happen in regular code because you would always have a TermRef at this point.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.